test: Cover paused-send timeout lifecycle #36873

pull john-lawniczak wants to merge 1 commits into bitcoin:master from john-lawniczak:pr/test-paused-send-timeout changing 2 files +79 −0
  1. john-lawniczak commented at 6:04 PM on November 14, 2026: none

    Adds deterministic regression coverage for the paused-send timeout introduced in #36667. Production behavior is unchanged.

    Checks that enqueueing and send attempts preserve the original pause timer despite recent activity; expiration occurs strictly after TIMEOUT_INTERVAL; and draining sends bytes, clears the pause, and permits a fresh interval.

    Uses mock time, a null socket while paused, and ZeroSock for draining. This does not test real backpressure, partial writes, handshakes, or concurrent behavior.

    Validation of the submitted file contents:

    • macOS arm64 Debug: focused test, full net_tests, formatting and whitespace checks passed.
    • Docker Linux arm64 native_nowallet: 364 CTest entries passed; 392 functional passes, 87 configured skips.
    • native_asan: 382 CTest entries passed; 491 functional passes, 12 configured skips.
    • win64: full cross-build passed, including test_bitcoin and installer; no Windows runtime tests.
    • native_tsan: all 381 CTest entries passed. The functional run failed in tool_wallet.py: its file-size limit truncates LLVM 23.1.6 TSan's temporary backing file, causing SIGBUS/exit 66. A standalone C++ program reproduces this without Bitcoin code. Two supplemental wallet startup failures associated with OOM kills passed isolated serial reruns.

    Keeping this draft because the full TSan job is not passing. No tests or sanitizer checks were disabled to obtain a pass.

    AI assistance was used for implementation, review, validation, and this description.

  2. test: Cover paused-send timeout lifecycle
    Exercise the paused-send timeout independently of recent send and receive
    activity. Check that enqueueing and send attempts preserve the original
    pause time, the timeout boundary remains exclusive, and draining the
    buffer permits a subsequent pause to start a fresh interval.
    
    Use a mock clock and existing socket test doubles for deterministic
    coverage. Verify that draining sends bytes before the pause clears.
    Production networking behavior is unchanged.
    d16fa8d167
  3. DrahtBot added the label Tests on Nov 14, 2026
  4. DrahtBot commented at 6:05 PM on November 14, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. achow101 commented at 9:07 PM on November 14, 2026: member

    This appears to violate our AI policy

  6. achow101 closed this on Nov 14, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-16 00:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me