test: cover null output validation in raw transactions #36899

pull Pranav-error wants to merge 1 commits into bitcoin:master from Pranav-error:test-createrawtransaction-null-outputs changing 1 files +1 −0
  1. Pranav-error commented at 8:35 AM on November 17, 2026: none

    There was no functional test covering the null output validation in NormalizeOutputs() at rawtransaction_util.cpp:88.

    This adds an assert_raises_rpc_error check to the existing invalid outputs block in rpc_rawtransaction.py, verifying that passing a null output raises RPC error -8 with the expected message: Invalid parameter, output argument must be non-null.

    The test passes with the expected error message, and changing the expected message makes it fail, confirming that the assertion is actually being executed.

    Validated by running rpc_rawtransaction.py successfully.

  2. test: cover null output validation in raw transactions
    Add a functional test for the null output error in NormalizeOutputs.
    f88ca1afb6
  3. DrahtBot added the label Tests on Nov 17, 2026
  4. DrahtBot commented at 8:35 AM on November 17, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. maflcko commented at 8:55 AM on November 17, 2026: member

    thx, but this is a bit too much of an edge case to be worth it to test.

  6. maflcko closed this on Nov 17, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-18 16:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me