Fix crash in importwallet and dumpwallet formatting #3691

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_02_importwallet_fix changing 1 files +3 −3

laanwj commented at 10:39 AM on February 17, 2014: member
- DecodeDumpTime was passing a statically allocated facet object to std::locale. However, "The constructed locale object takes over responsibility for deleting this facet object." causing a free() crash on scope exit. Fixes #3670.
- EncodeDumpTime was using the wrong format character for dates (appears accidentally introduced in 51ed9ec9)
BitcoinPullTester commented at 11:13 AM on February 17, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/0f533aca90665dbb8e3246947df738da2136c2c6 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
jgarzik commented at 1:58 PM on February 17, 2014: contributor

ACK

in src/rpcdump.cpp:None in 0f533aca90 outdated

  30 |  int64_t static DecodeDumpTime(const std::string &str) {
  31 | -    static boost::posix_time::time_input_facet facet("%Y-%m-%dT%H:%M:%SZ");
  32 |      static const boost::posix_time::ptime epoch = boost::posix_time::from_time_t(0);
  33 | -    const std::locale loc(std::locale::classic(), &facet);
  34 | +    static const std::locale loc(std::locale::classic(),
  35 | +            new boost::posix_time::time_input_facet("%Y-%m-%dT%H:%M:%SZ"));

Diapolo commented at 3:11 PM on February 17, 2014:

Indentation-nit :-P

gavinandresen commented at 5:09 PM on February 17, 2014: contributor

ACK

Fix crash in importwallet and dumpwallet formatting

- DecodeDumpTime was passing a statically allocated facet object to
  std::locale. However, "The constructed locale object takes over
  responsibility for deleting this facet object." causing a free()
  crash on scope exit. Fixes #3670.

- EncodeDumpTime was using the wrong format character for dates
  (appears accidentally introduced in 51ed9ec9)

a143d4ce58

laanwj commented at 5:43 PM on February 17, 2014: member

@diapolo "fixed" indentation
laanwj referenced this in commit 0a0cf14337 on Feb 17, 2014
laanwj merged this on Feb 17, 2014
laanwj closed this on Feb 17, 2014
laanwj deleted the branch on Apr 9, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Linked (view graph)

#3670 importwallet method is working or not?