Add interoperable BIP-329 wallet label import and export #36910

issue victrvondoom opened this issue on November 18, 2026
  1. victrvondoom commented at 4:48 PM on November 18, 2026: none

    Bitcoin Core wallets can manage address labels through RPCs such as setlabel, getaddressesbylabel, and listlabels, but they do not appear to support importing or exporting labels in the interoperable BIP-329 JSON Lines format. This leaves users who move between compatible wallets to recreate metadata manually, even though labels can carry privacy-relevant context about transaction and address history.

    Could Core add a BIP-329 import/export path for the record types its wallet can represent, with explicit handling for unsupported types and round-trip functional tests? This would complement existing wallet backup/migration while keeping the format's scope and compatibility limitations clear. The current label RPC surface is implemented in src/wallet/rpc/addresses.cpp; searches for BIP-329 support or an existing import/export proposal did not find an implementation or matching issue/PR.

  2. victrvondoom commented at 5:33 PM on November 19, 2026: none

    I can take this up; please assign me if the direction is accepted. An efficient implementation would reuse the wallet label/metadata path, map only the BIP-329 record types Core can represent, and add round-trip tests for supported, malformed, and unsupported records while preserving the existing wallet behavior. The less-obvious factor is that labels can contain sensitive personal context: import should avoid partial wallet changes on invalid input, and export must not leak the payload through logs or an unexpected output path. I would make those failure and output semantics explicit before adding the interface.

  3. maflcko commented at 5:49 PM on November 19, 2026: member

    LLM generated content is not allowed in comments/communications. See https://github.com/bitcoin/bitcoin/blob/master/doc/AI_POLICY.md

    The bottleneck in this project has always been review and testing, not writing code. Development here is intentionally conservative and slow, and reviewer attention is the scarcest resource we have. LLMs have made this worse, anyone can now prompt them and post their output as PRs. There is an infinite amount plausible looking "improvements" for LLMs to suggest and work on.

    Unless we fully trust LLMs to both write and review code, humans still have to spend time understanding the proposed changes, which incurs a non-zero cost for every opened PR.

    I understand that contributing to this project can be intimidating, and using LLMs may seem tempting, but it really creates more issues for this project than it solves. The best way to help this project, is to review and test changes. You can use LLMs for this, but you shouldn't solely rely on them, or just post their output.

    I am asking you to reconsider whether it's something you genuinely think the project should pursue, independent of what your LLM suggested.

    See https://github.com/bitcoin/bitcoin/blob/master/doc/AI_POLICY.md

  4. maflcko closed this on Nov 19, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-19 19:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me