[Qt] small .ui cleanup for optionsdialog and coincontrol #3693

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:ui-cleanup changing 2 files +80 −83

Diapolo commented at 2:52 PM on February 17, 2014: none

Use a normal layout in coincontrol.ui and fix some small naming glitches in optionsdialog.ui and add a shortcut to the new "Spend unconfirmed change" setting.
[Qt] small .ui cleanup for optionsdialog and coincontrol f05fa03e8b
in src/qt/forms/optionsdialog.ui:None in f05fa03e8b
```
 151 | @@ -152,7 +152,7 @@
 152 |        <attribute name="title">
 153 |         <string>W&amp;allet</string>
 154 |        </attribute>
 155 | -      <layout class="QVBoxLayout" name="verticalLayout_Network">
 156 | +      <layout class="QVBoxLayout" name="verticalLayout_Wallet">
```
laanwj commented at 3:19 PM on February 17, 2014:

Why are you naming the spacers specifically? We never refer to them. This is really over-doing things. If you keep them at the default spacer1 2 3 names you never have to rename them.

Diapolo commented at 3:30 PM on February 17, 2014:

You are right (and I won't name them again), but as they now have the wrong name ;)...

laanwj commented at 3:35 PM on February 17, 2014:

So if you rename them anyway, please just name them verticalLayout / verticalLayout2 / etc and remove the _Wallet _Network part. Naming them specifically just gives extra maintenance (and review) effort without a good reason. Same for the label change below.
BitcoinPullTester commented at 3:36 PM on February 17, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f05fa03e8bfe806eae60c1de4a7780efa5aa8e04 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 5c99323459 on Feb 18, 2014
laanwj merged this on Feb 18, 2014
laanwj closed this on Feb 18, 2014
Diapolo deleted the branch on Feb 18, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester