qt: Rename 'Confirmed' balance to 'Spendable' on overview page #3699

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_02_qt_confirmed_balance_spendable changing 1 files +2 −2
  1. laanwj commented at 12:21 PM on February 18, 2014: member

    The word 'Spendable' more precisely says what the balance actually means. It is not always 'confirmed' (for example in the case of spending unconfirmed change #3676).

    scr2

  2. BitcoinPullTester commented at 12:55 PM on February 18, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/5de9e8712f55937bec3c35be5cbfa064493db2b4 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  3. Diapolo commented at 1:26 PM on February 18, 2014: none

    ACK

    Are there any more places, where this needs to be change?

  4. laanwj commented at 1:31 PM on February 18, 2014: member

    A quick git grep in src/qt and src/qt/locale didn't show up any other misuses of Confirmed. In other places (like the send tab) the spendable balance is just called 'balance' and is the only one shown, which is good too.

  5. Diapolo commented at 2:09 PM on February 18, 2014: none

    That's indeed a good thing, just merge then :).

  6. luke-jr commented at 5:15 PM on February 18, 2014: member

    "Available" might be better, to match existing online banking terminology.

  7. ghost commented at 5:38 PM on February 18, 2014: none

    @luke-jr ACK, available is more appropriate and what is in use in the mainstream.

  8. cozz commented at 9:33 PM on February 18, 2014: contributor

    If we rename "confirmed" to "available" then how about renaming "unconfirmed" to "pending"?

  9. sipa commented at 9:37 PM on February 18, 2014: member

    available and pending sound good to me

  10. int03h commented at 10:10 PM on February 18, 2014: none

    Nit picking :

    Definition from Oxford : http://www.oxforddictionaries.com/us/definition/american_english/pending

    to summarise : Pending - until (something) happens or takes place.

    Pending is a preposition .. so it should be pending confirmation or pending something else it shouldn't be used on its own ..

  11. ghost commented at 10:14 PM on February 18, 2014: none

    @int03h Technically, "pending confirmation", but "pending" by itself works since us humans have lenient language parsers :)

    My bank uses 'current *' and 'available *' (balance)

  12. luke-jr commented at 10:16 PM on February 18, 2014: member

    My bank uses "Current Balance" and "Available Balance".

  13. int03h commented at 11:38 PM on February 18, 2014: none

    those terms are unoffensive to me or the english language ;) (ie +1 for lukes-jr's suggestion.)

  14. laanwj commented at 7:38 AM on February 19, 2014: member

    Going to go with available (which implies it can be spent now and is really there) and pending (which implies that there is a time factor involved, which there is).

  15. qt: Rename 'Confirmed' balance to 'Spendable' on overview page
    The word 'Spendable' more precisely says what the balance actually means.
    
    Avoids the confirmed/unconfirmed confusion that can be caused by #3676.
    ddcabae0de
  16. laanwj referenced this in commit 38ebd0fee8 on Feb 19, 2014
  17. laanwj merged this on Feb 19, 2014
  18. laanwj closed this on Feb 19, 2014

  19. ghost commented at 10:51 AM on February 19, 2014: none

    @laanwj good choice!

  20. laanwj deleted the branch on Apr 9, 2014
  21. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me