Category "conflicted" contradicts documentation #3710

issue cozz opened this issue on February 20, 2014

cozz commented at 12:07 PM on February 20, 2014: contributor
Looking at the help output of listtransactions, there are sentences like:
- txid: Available for 'send' and 'receive' category of transactions.
- fee: This is negative and only available for the 'send' category of transactions.
... and some more.

I was thinking, that a boolean flag "conflicted" true/false could be the better choice than category "conflicted". I think a transaction is still category send/receive, but then conflicted=true/false.

Some opinions on this, flag vs. category would be good.
laanwj commented at 12:17 PM on February 20, 2014: member

In the GUI 'conflicted' is a transaction status (like confirmed, unconfirmed, immature, it changes over time), it is orthogonal to the send/received/sendtoself/generated type (which cannot ever change).
laanwj added the label Brainstorming on Feb 20, 2014
gavinandresen commented at 1:49 PM on February 20, 2014: contributor

confirmations -1 means conflicted (so a conflicted boolean would be redundant), so just removing the 'conflicted' category is probably the right thing to do.
freewil commented at 3:29 PM on February 21, 2014: contributor

so just removing the 'conflicted' category is probably the right thing to do.

:+1: makes sense to me.
laanwj commented at 3:30 PM on February 21, 2014: member

Agreed @gavinandresen
laanwj commented at 3:35 PM on February 21, 2014: member

See #3720
cozz closed this on Feb 22, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels