script: tighten multisig non-standard rules: do not relay pubkeys above 65 bytes #3718

1. 
   jgarzik commented at 7:29 am on February 21, 2014: contributor

   As suggested by @petertodd.
2. script: tighten multisig non-standard rules: do not relay pubkeys above 65 bytes 595b6d88d4
3. 
   petertodd commented at 7:35 am on February 21, 2014: contributor

   ACK
4. 
   BitcoinPullTester commented at 8:04 am on February 21, 2014: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/595b6d88d41c0cadf9411b3aaef5585e2060e739 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
5. in src/script.cpp: in 595b6d88d4

   1260@@ -1261,7 +1261,7 @@ bool Solver(const CScript& scriptPubKey, txnouttype& typeRet, vector<vector<unsi
   1261             // Template matching opcodes:
   1262             if (opcode2 == OP_PUBKEYS)
   1263             {
   1264-                while (vch1.size() >= 33 && vch1.size() <= 120)
   1265+                while (vch1.size() >= 33 && vch1.size() <= 65)
   

   ---

   ---

   

   Diapolo commented at 8:19 am on February 21, 2014:

   That’s one of those magic numbers that we should perhaps constantify?

   ---

   

   laanwj commented at 8:50 am on February 21, 2014:

   It may be that using the explicit numbers here actually makes the rules more readable than using a named constant. OTOH some form of documentation as to why certain numbers were chosen in the source code would be useful.
6. 
   laanwj commented at 3:37 pm on February 21, 2014: member

   ACK
7. 
   gavinandresen commented at 4:04 pm on February 21, 2014: contributor

   Untested ACK.
8. jgarzik referenced this in commit c72204e568 on Feb 24, 2014
9. jgarzik merged this on Feb 24, 2014
10. jgarzik closed this on Feb 24, 2014

    ---

11. jgarzik deleted the branch on Aug 24, 2014
12. DrahtBot locked this on Sep 8, 2021

Contributors
jgarzik petertodd BitcoinPullTester Diapolo laanwj gavinandresen