'sendrawtransaction' improvements #3730

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_02_rpcrawtx_improvements changing 2 files +17 −16

laanwj commented at 11:05 AM on February 22, 2014: member
- Make it report the reject code and reason (and reserve a new error code in rpcprotocol.h for this)
- Make it possible to re-send transactions that are already in the mempool
laanwj commented at 7:41 AM on February 23, 2014: member
Right, the idea would be that the error when RPC_TRANSACTION_REJECTED can be easily parsed to get the reject code, and that it is only returned when the transaction was rejected and not when something else goes wrong in the function.
- If you'd asked me, I don't think 'already in blockchain' is an error at all! It would be better as a return value {'alreadyinmempool':..., 'alreadyinchain':..., 'txid':....}. I've just kept it for backwards compatibility but I'm not sure whether that's a good thing.
laanwj commented at 7:15 AM on February 25, 2014: member
- Apart from a transaction reject (!isValid), the CValidationState can also be an error (isError), I suppose different codes should be returned for those.
laanwj commented at 10:48 AM on March 27, 2014: member

No one with any opinion on these things?

'sendrawtransaction' improvements

- Make it report the reject code and reason
- Make it possible to re-send transactions that are already in the mempool

1d46fe3327

laanwj commented at 11:35 AM on March 27, 2014: member

Added separate error codes for the RPC_TRANSACTION_REJECTED / RPC_TRANSACTION_ERROR / RPC_TRANSACTION_ALREADY_IN_CHAIN cases.
BitcoinPullTester commented at 12:10 PM on March 27, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/1d46fe3327f6645fd79b442cd72ef422418c1a50 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
jgarzik commented at 1:46 PM on March 27, 2014: contributor

ACK
laanwj referenced this in commit acac57b8af on Mar 28, 2014
laanwj merged this on Mar 28, 2014
laanwj closed this on Mar 28, 2014
laanwj deleted the branch on Apr 9, 2014
DrahtBot locked this on Sep 8, 2021

Contributors