[QT] Fixes feel when resizing the last column on tables (issue #2862) #3738

1. 
   gubatron commented at 3:08 AM on February 25, 2014: contributor

   Re-submitting this pull request with a single commit.

   This patch introduces a GUIUtil class that is used when setting up the 2 tables we have so far on the Qt-GUI. In the past you could only resize the last column, which has BTC amounts from the right border of the column header, something that was rather unnatural.

   If a new table were ever to be added to the interface, fixing the last columns resizing behavior is rather simple. Just look at how we initialize here a TableViewLastColumnResizingFixer object when setting up the table header's behavior, and then how we override the resize event of the component (can be the table, or the dialog) and we invoke columnResizingFixer->adjustTableColumnsWidth();

2. laanwj added this to the milestone 0.10.0 on Feb 28, 2014
3. 
   laanwj commented at 7:41 AM on March 1, 2014: member

   ACK on code changes, haven't tested yet.

4. 
   gubatron commented at 5:08 PM on March 3, 2014: contributor

   @laanwj there's one more small detail I think you will notice when you test that I need to fix (so no rush on merging yet, I'm hoping to get sometime to fix this hopefully today)

   Basically the issue is after resizing the window, only the visible table is adjusting, if you switch to another view, the other table won't be adjusted until you interact with it.

   I'm looking for a signal that I can use to notify the table fixing object atm, if not my guess is that I'll have to override another onSomeEvent method, but I want to stay away from that to keep the fixes outside the TableViewLastColumnResizingFixer to a minimum.

5. QT issue #2862. Fixes feel when resizing the last column on tables.

   added last fix for glitch when window was resized and tab switches were performed.
   code simplified, no need for `geometriInitialized` state to be kept anymore.

   8ca8026a52
6. 
   gubatron commented at 9:03 PM on March 11, 2014: contributor

   this should be done now.

   I tried to squash my 2 commits into one using git rebase -i HEAD~2 everything went fine, but when I tried to push my changes, I was told to pull, and when I pulled that empty 'merge' commit would be added to the history, no clue how to remove it and make it all look as a single commit.

   any git help would be appreciated.

7. 
   int03h commented at 9:07 PM on March 11, 2014: none

   @gubatron I am also wrestling this bear to the ground here : https://github.com/bitcoin/gitian.sigs/pull/19

   Take a look and see if it helps. (scroll down a bit to get to the part that may be of assistance )

8. 
   cozz commented at 9:15 PM on March 11, 2014: contributor

   git push --force origin branchname

9. 
   gubatron commented at 9:41 PM on March 11, 2014: contributor

   thank you guys (man do I love this community)

10. 
    gubatron commented at 9:44 PM on March 11, 2014: contributor

    yay.

    Solved with

    git reset --hard HEAD~1 #to get rid of the merge git push --force #overwrite my remote fork. always scary to do push force.

11. 
    gubatron commented at 4:53 PM on March 14, 2014: contributor

    Here's a video of what the patch does. https://www.youtube.com/watch?v=BhidXDza7sU&feature=youtu.be

    has anybody been able to test on a windows machine? I don't have a windows development environment.

    I'll test in Ubuntu in the meantime.

12. 
    laanwj commented at 9:46 AM on March 17, 2014: member

    Works for me on Ubuntu + Qt 5.0.2.

13. 
    laanwj commented at 9:49 AM on March 17, 2014: member

    BTW: needs rebase for some changes in receivecoinsdialog

14. 
    cozz commented at 4:03 PM on March 17, 2014: contributor

    Just tested on qt4 and qt5.2. The resizing works very good, would be great if the stretching behavior could be improved.

    Start bitcoin-qt without a config file, so in window mode. and then maximize the window:

    Before:

    After:

    The column amount gets stretched instead of message. @gubatron Is it possible to fix this, to get the old stretching behavior back?

15. 
    gubatron commented at 5:05 PM on March 17, 2014: contributor

    @laanwj will fix it.

16. when resizing the window, the second to last column stretches, new public method stretchColumnWidth added. a148354476
17. merging latest changes. 449694f0ec
18. 
    BitcoinPullTester commented at 5:30 AM on March 21, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/449694f0ecaed68a2b2f9c6560fd7a3c25fd15cb for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

19. gubatron closed this on Mar 21, 2014

    ---

20. gubatron deleted the branch on Mar 21, 2014
21. MarcoFalke referenced this in commit fd725c2d79 on Feb 22, 2021
22. sidhujag referenced this in commit c7a0f8cbd4 on Feb 22, 2021
23. unknown approved
24. fanquake locked this on Aug 12, 2021

Milestone
0.10.0