Display blocks received without needing debug=net #3739

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:DisplayBlocksReceivedWithoutDebug changing 1 files +1 −1

rebroad commented at 4:37 AM on February 25, 2014: contributor

Too much debug info is shown when debug=net, but blocks received is useful info that most people will want to see without debug=net set.
Display blocks received without needing debug=net 6047965213

laanwj commented at 1:14 PM on May 28, 2014: member

We already get the message

2014-05-28 07:07:28 UpdateTip: new best=000000000000000004ba6752f1ce5f70e28c494325bd7620602d05a469a256ef  height=302985  log2_work=78.846423  tx=39632548  date=2014-05-28 07:06:38 progress=0.999998

for each block, making it more spammy doesn't seem useful to me. If you want more spam, just enable the net debug category.

BitcoinPullTester commented at 3:39 PM on June 23, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p3739_6047965213be126cfab50c163fa5005b30507002/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 3:50 PM on June 23, 2014: member

NACK. No need for more spam by default.
laanwj closed this on Jun 23, 2014
rebroad deleted the branch on Jun 27, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

rebroad

laanwj

BitcoinPullTester