Revert to previous behaviour before LogPrintf code was added - i.e. display certain network related debug messages without needing debug=net set in bitcoin.conf.
Don't need debug=net to display some debug lines. #3740
pull rebroad wants to merge 2 commits into bitcoin:master from rebroad:DisplaySomeNetDebugAlways changing 1 files +9 −9-
rebroad commented at 4:50 AM on February 25, 2014: contributor
-
Don't need debug=net to display some debug lines. cca7c45c90
-
c1eb53165b
Correct logic so that not both lines are displayed
e.g.:- 2014-02-25 06:56:39 received getdata (1 invsz) 2014-02-25 06:56:39 received getdata for: tx 8e2e08d1d851eb1ac800e814796dd7b86fd6d3a8fad41d5bdcb873ac6f4aba8d
-
BitcoinPullTester commented at 7:47 AM on February 25, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c1eb53165b6ffdee7b0b745d1d74f621210cd1b9 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 7:51 AM on February 28, 2014: member
I see no point personally for logging these details while not having debug=net. If you want to debug networking, why not add debug=net? That's what the option was created for.
-
rebroad commented at 6:39 PM on February 28, 2014: contributor
@laanwj because currently debug=net creates a lot of superfluous information in debug.log - can we make the levels of debugging net more granular? How would you like the command line option to be designed for different levels of net debugging please? debug=net1 or debug=net2 perhaps? or perhaps debugnet=1 or debugnet=2 ?
-
laanwj commented at 9:08 AM on March 1, 2014: member
That's a fair comment --
-debug=netis very noisy. I just don't agree on this solution. -
- rebroad closed this on May 16, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors