Replace PrintException with PrintExceptionContinue + throw #3749

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_02_printexception changing 3 files +10 −15

laanwj commented at 12:27 PM on February 26, 2014: member

Just a pet peeve (@cozz likely agrees).

(PrintException has exactly the same body as PrintExceptionContinue but does a re-throw at the end. Move these re-throws to the call site, this aids understanding what is going on as well as eliminates a bit of code duplication in util.cpp)

Replace PrintException with PrintExceptionContinue + throw

Just a pet peeve.

(PrintException has exactly the same body as PrintExceptionContinue but
does a re-throw at the end. Move these re-throws to the call
site, this aids understanding what is going on as well as eliminates a
bit of code duplication in util.cpp)

44235713ed

BitcoinPullTester commented at 1:04 PM on February 26, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/44235713ed0ad1810328f21108d32bbac04de87b for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
cozz commented at 1:04 PM on February 26, 2014: contributor

Easy ACK :)
gavinandresen commented at 1:29 PM on February 26, 2014: contributor

ACK
laanwj referenced this in commit b81f9718df on Feb 26, 2014
laanwj merged this on Feb 26, 2014
laanwj closed this on Feb 26, 2014
laanwj deleted the branch on Apr 9, 2014
DrahtBot locked this on Sep 8, 2021

Contributors