Change linux gitian.sigs dir names to match windows #3775

1. 
   Michagogo commented at 7:01 PM on March 1, 2014: contributor

   At the moment, linux sigs are marked with just the version, while windows sigs are marked with the version with -win appended. I don't see any reason why this should be the case. The logic is the same as renaming gitian.yml to gitian-linux.yml.

   Also, this fixes an unbalanced paranthesis.

2. gavinandresen added the label Improvement on Mar 1, 2014
3. gavinandresen added the label Priority Low on Mar 1, 2014
4. 
   int03h commented at 2:30 AM on March 2, 2014: none

   NACK. (if I may)

   As I understand it that line builds all of them. Not just linux. There is a comment about 3 lines up that says that but I agree the script it is calling is misleadingly named.

5. 
   Michagogo commented at 6:38 AM on March 2, 2014: contributor

   @int03h Uh, I'm not sure exactly what you're saying. Have you ever done a gitian build? The gsign script signs whatever was just built. Right now, Linux and Windows builds are done separately. You can tell by the names of the descriptors. Right now the $VERSION-win dir is the signature for the Windows build, and $VERSION is the Linux build. This just makes it clear.

6. 
   laanwj commented at 10:05 AM on March 2, 2014: member

   Makes sense, I suppose. This is too late for 0.9 but this convention can be used for the next release.

7. 
   Michagogo commented at 1:19 PM on March 2, 2014: contributor

   ...I must have been tired or distracted or something, not everything's properly changed, etc.

   I'll redo this.

8. Michagogo closed this on Mar 2, 2014

   ---

9. 
   Michagogo commented at 5:20 PM on March 2, 2014: contributor

   Okay, let's try this again...

10. Michagogo reopened this on Mar 2, 2014

    ---

11. 
    Michagogo commented at 5:22 PM on March 2, 2014: contributor

    @laanwj What defines "too late" in this case? Why couldn't this go into 0.9.0, if we end up needing an rc3?

12. laanwj added this to the milestone 0.10.0 on Mar 7, 2014
13. 
    int03h commented at 2:01 PM on March 8, 2014: none

    ack and bump. Looking at it again I see why now. Sorry my fault for holding it wrong.

14. 
    laanwj commented at 10:05 AM on June 23, 2014: member

    Needs rebase

15. 
    Michagogo commented at 10:42 AM on June 26, 2014: contributor

    Okay, I think it's rebased now.

16. Change linux gitian.sigs dir names to match windows

    At the moment, linux sigs are marked with just the version, while windows sigs are marked with the version with -win appended. I don't see any reason why this should be the case. The logic is the same as renaming gitian.yml to gitian-linux.yml.
    
    Also, this fixes an unbalanced paranthesis and a couple capitalization
    things.

    d68369764a
17. 
    BitcoinPullTester commented at 5:29 PM on June 26, 2014: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p3775_d68369764a1b78b76e1b508d78a64a7fde9cbf8c/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

18. Michagogo referenced this in commit 462ad223d6 on Jul 1, 2014
19. 
    Michagogo commented at 4:37 PM on July 1, 2014: contributor

    The changes from this PR are included (or, obsoleted) as part of PR #4449.

20. laanwj closed this on Jul 2, 2014

    ---

21. Michagogo deleted the branch on Dec 11, 2014
22. reddink referenced this in commit ae7b82b279 on May 27, 2020
23. DrahtBot locked this on Sep 8, 2021

Milestone
0.10.0