Fix coin control sorts date as text #3784

pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz2 changing 3 files +39 −10

cozz commented at 3:36 AM on March 3, 2014: contributor

Fixes #3783
laanwj commented at 7:00 AM on March 3, 2014: member

ACK (for 0.9 as well as master)
Fix coin control sorts date as text dc01ba7b0c

in src/qt/coincontroldialog.cpp:None in 75a74a8bef outdated

 335 | @@ -335,7 +336,7 @@ void CoinControlDialog::headerSectionClicked(int logicalIndex)
 336 |  {
 337 |      if (logicalIndex == COLUMN_CHECKBOX) // click on most left column -> do nothing
 338 |      {
 339 | -        ui->treeWidget->header()->setSortIndicator((sortColumn == COLUMN_AMOUNT_INT64 ? COLUMN_AMOUNT : (sortColumn == COLUMN_PRIORITY_INT64 ? COLUMN_PRIORITY : sortColumn)), sortOrder);
 340 | +        ui->treeWidget->header()->setSortIndicator((sortColumn == COLUMN_AMOUNT_INT64 ? COLUMN_AMOUNT : (sortColumn == COLUMN_PRIORITY_INT64 ? COLUMN_PRIORITY : (sortColumn == COLUMN_DATE_INT64 ? COLUMN_DATE : sortColumn))), sortOrder);

laanwj commented at 9:57 AM on March 3, 2014:

This mapping is repeated a few times. I'd propose adding functions to map from real column to hidden column and vice versa.

cozz commented at 3:57 PM on March 3, 2014:

Makes sense. Should this be part of this or new pull request?

laanwj commented at 4:00 PM on March 3, 2014:

No need for a new pull, you can just push it here, I'll wait with merging

cozz commented at 10:31 PM on March 3, 2014: contributor
update:
- add mapping function between visible <-> hidden columns
BitcoinPullTester commented at 11:44 PM on March 3, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/dc01ba7b0c203afa78c3312293e0432d680f5d63 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 9:12 AM on March 4, 2014: member

For some reason I'm not seeing anything in the date and confirmation columns anymore
cozz commented at 10:33 AM on March 4, 2014: contributor

@laanwj I assume you are talking about the header item in tree mode only, we had never shown those columns there... Just open up the tree or switch to list mode and you should see them.
laanwj commented at 11:18 AM on March 4, 2014: member

Oh right, my bad
laanwj referenced this in commit c975e99ca9 on Mar 4, 2014
laanwj merged this on Mar 4, 2014
laanwj closed this on Mar 4, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

cozz

laanwj

BitcoinPullTester

Linked (view graph)

#3783 Windows .9.0 (x64) coin control sorts date as text, not date.