requesting tx that are already in the memory pool #3788

bitcoind is requesting transactions that are already in the memory pool. debug.log extract below:-

2014-03-03 20:24:19 askfor tx 11acc2f0cefaa8e70676e26e6dfa7da82efdc5bfc36da2cad50041fd240a984b 0 (00:00:00) node=3 2014-03-03 20:24:19 sending getdata: tx 11acc2f0cefaa8e70676e26e6dfa7da82efdc5bfc36da2cad50041fd240a984b node=3 2014-03-03 20:24:20 askfor tx 11acc2f0cefaa8e70676e26e6dfa7da82efdc5bfc36da2cad50041fd240a984b 1393878258823154 (20:24:18) node=4 2014-03-03 20:24:20 AcceptToMemoryPool: node=3 : accepted 11acc2f0cefaa8e70676e26e6dfa7da82efdc5bfc36da2cad50041fd240a984b (poolsz 287) 2014-03-03 20:26:21 sending getdata: tx 11acc2f0cefaa8e70676e26e6dfa7da82efdc5bfc36da2cad50041fd240a984b node=4 2014-03-03 20:26:21 ERROR: AcceptToMemoryPool : inputs already spent 2014-03-03 20:26:21 node=4 11acc2f0cefaa8e70676e26e6dfa7da82efdc5bfc36da2cad50041fd240a984b was not accepted into the memory pool: bad-txns-inputs-spent

I'm pretty sure that this is fixed. The handling for the inv message checks AlreadyHave before requesting the transaction, which checks whether a transaction is already in the memory pool.