Do not use comma as thousands separator #379
pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:nocommas changing 1 files +0 −7-
gavinandresen commented at 1:50 pm on July 4, 2011: contributorUsing the comma as thousands separator causes problems for parts of the world where comma == decimal point. Germans sending 0,001 bitcoins are unpleasantly surprised when that results in 1 BTC getting sent.
-
Do not use comma as thousands separator
Using the comma as thousands separator causes problems for parts of the world where comma == decimal point. Germans sending 0,001 bitcoins are unpleasantly surprised when that results in 1 BTC getting sent.
-
sgimenez commented at 5:00 pm on July 4, 2011: contributor
There is also an overflow problem with ParseMoney. Maybe this should be fixed in the same time.
0"10000000000" -> Parse and Format -> "10,000,000,000.00" (ok) 1"100000000000" -> Parse and Format -> "-84,467,440,737.09551616" (not ok) 2"1000000000000" -> Parse and Format -> "77,662,796,314.5224192" (not ok)
etc.
Of course there is this limit of ~21 MBTC, but I think it’s safer to prevent overflows. Who knows, someone might try to input fictive money amounts.
-
jgarzik commented at 10:47 pm on July 4, 2011: contributor
ACK
Should this be pulled for 0.3.24?
-
gavinandresen referenced this in commit 9390431ce4 on Jul 5, 2011
-
gavinandresen merged this on Jul 5, 2011
-
gavinandresen closed this on Jul 5, 2011
-
lateminer referenced this in commit e139e61060 on Oct 16, 2019
-
rajarshimaitra referenced this in commit 199e9357be on Aug 5, 2021
-
DrahtBot locked this on Sep 8, 2021
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 04:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-29 04:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me