Fix null pointer in IsTrusted() #3804

pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz2 changing 1 files +3 −1

cozz commented at 2:12 PM on March 5, 2014: contributor
Use case:
- create a rawtransaction with 2 inputs from 2 different private keys
- start bitcoin with a new wallet
- import 1 of the private keys
- sendrawtransaction
- => segfault
I guess the reason is that IsFromMe() is true for the transaction, but the parent transaction of the other input is not part of the wallet. I have currently a state on my pc, where I can trigger a segfault everytime with a new wallet, just by importing a private key and then send a rawtransaction. Did not segfault with this fix applied.
Fix null pointer in IsTrusted() ba51c7da40
BitcoinPullTester commented at 2:26 PM on March 5, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ba51c7da408fad7986d52206ed30e181091c1a95 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 2:58 PM on March 5, 2014: member

Good catch!
gavinandresen commented at 5:59 PM on March 5, 2014: contributor

ACK. Lets get this into a 0.9.0rc3 release.

On Wed, Mar 5, 2014 at 9:58 AM, Wladimir J. van der Laan < notifications@github.com> wrote:

Good catch!

Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/pull/3804#issuecomment-36749986 .

Gavin Andresen
laanwj referenced this in commit f5352da490 on Mar 5, 2014
laanwj merged this on Mar 5, 2014
laanwj closed this on Mar 5, 2014
DrahtBot locked this on Sep 8, 2021

Contributors