...there is no reason to check separately. Also, the function is only checking fees for one transaciton, so there is no reason to keep a running total of fees (nFees = 0 + nTxFee).
Code cleanup: MoneyRange() chcks if the passed in value is negative, so ... #3818
pull maaku wants to merge 1 commits into bitcoin:master from maaku:minor-code-cleanup-2 changing 1 files +2 −7-
maaku commented at 8:53 PM on March 7, 2014: contributor
-
Code cleanup: MoneyRange() chcks if the passed in value is negative, so there is no reason to check separately. Also, the function is only checking fees for one transaciton, so there is no reason to keep a running total of fees (nFees = 0 + nTxFee). c820ff60e2
-
BitcoinPullTester commented at 9:16 PM on March 7, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c820ff60e270b66c535536899dabccfc30aa57c1 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 7:11 AM on March 8, 2014: member
NACK. I like the explicit checks here, and also the explicit error message for negative fees.
-
-
gavinandresen commented at 3:58 PM on March 10, 2014: contributor
Closing. Belts and suspenders are stylish.
- gavinandresen closed this on Mar 10, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors