Added eclipse project files to gitignore #3836

pull alonmuroch wants to merge 2 commits into bitcoin:master from alonmuroch:master changing 1 files +4 −0

alonmuroch commented at 5:31 PM on March 10, 2014: contributor

added .cproject, .project files to .gitignore under #eclipse
commit after make 308b1ba135
added .project and .cproject to git ignore under #eclipse 61ca1ad8aa
ghost commented at 5:44 PM on March 10, 2014: none

NACK from me. These sort of things belong in your global .gitignore and not in every project. see https://help.github.com/articles/ignoring-files#create-a-global-gitignore

If anything the project level .gitignore should be cleaned up, not added to, so it only contains ignores for things that are specific to the project (like compiled objects and all the noise compiler creates etc). IDE and OS exclusions belong in a user's own global ignore.
alonmuroch closed this on Mar 10, 2014
BitcoinPullTester commented at 5:51 PM on March 10, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/61ca1ad8aa7c00ebe9e18a1ef0e4bf339da99f60 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
DrahtBot locked this on Sep 8, 2021

Contributors