Make mining fee policy match relay fee policy. #3838

1. 
   mikehearn commented at 6:37 pm on March 10, 2014: contributor

   This resolves a case in which a mismatch could be used to bloat up the mempool by sending transactions that pay enough fee to relay, but not to be mined, with the default policies.
2. Make mining fee policy match relay fee policy.

   This resolves a case in which a mismatch could be used to bloat up the
   mempool by sending transactions that pay enough fee to relay, but not
   to be mined, with the default policies.

   037b4f1485
3. 
   gavinandresen commented at 6:52 pm on March 10, 2014: contributor

   ACK, but lets not forget to mention this in the release notes.
4. 
   BitcoinPullTester commented at 7:06 pm on March 10, 2014: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/037b4f1485404a69f96ac6c448a97d21315c8663 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
5. 
   ghost commented at 7:06 pm on March 10, 2014: none

   Shouldn’t this PR apply to 0.9.0 branch so it can then be merged up into master?
6. 
   sipa commented at 8:01 pm on March 10, 2014: member

   We have a policy of only pulling in changes in side branches that have been merged into master, just to make reasoning easier of what is where. This means that pull requests should always be for master (well, perhaps except for readme/release notes specific to a release).
7. 
   jgarzik commented at 8:05 pm on March 10, 2014: contributor

   Correct. Default is “upstream first” (==master), then backport. This helps ensure bug fixes are not lost.
8. 
   laanwj commented at 9:29 am on March 11, 2014: member

   Would be nice to move nMinTxFee constant to wallet.cpp/h at some point, as it now only affects the wallet.

   After this commit there is only one use of nMinTxFee remaining outside wallet.cpp and the options parsing, in GetMinFee ( https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L781 ).

9. laanwj added this to the milestone 0.9.0 on Mar 11, 2014
10. gavinandresen merged this on Mar 11, 2014
11. gavinandresen closed this on Mar 11, 2014

    ---

12. 
    gavinandresen commented at 3:32 pm on March 11, 2014: contributor

    Merged into master and 0.9.0 (and doc/release-notes.md in the 0.9.0 branch updated).
13. luke-jr referenced this in commit c66d773518 on May 30, 2015
14. luke-jr referenced this in commit 20aac3a445 on May 30, 2015
15. luke-jr referenced this in commit e4722cb899 on May 30, 2015
16. luke-jr referenced this in commit 68f8c55141 on May 30, 2015
17. luke-jr referenced this in commit e925c34086 on May 31, 2015
18. DrahtBot locked this on Sep 8, 2021

Contributors
mikehearn gavinandresen BitcoinPullTester ghost sipa jgarzik laanwj