Add script test to prove that OP_0 evaluates as the empty vector, rather than [0].
Add script test to prove that OP_0 evaluates as the empty vector. #3841
pull schildbach wants to merge 1 commits into bitcoin:master from schildbach:script-tests-OP_0 changing 2 files +6 −2-
schildbach commented at 11:27 PM on March 10, 2014: contributor
-
schildbach commented at 11:36 PM on March 10, 2014: contributor
Also see https://github.com/bitcoinj/bitcoinj/pull/27 for the bitcoinj side of tests and a bit of history why this is important.
-
Add script test to prove that OP_0 evaluates as the empty vector, rather than [0]. ffd082a6a3
-
BitcoinPullTester commented at 12:41 AM on March 11, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ffd082a6a36bf0b85078be8400b8eda3630b34b3 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
gavinandresen commented at 1:03 AM on March 11, 2014: contributor
ACK
-
petertodd commented at 6:25 AM on March 11, 2014: contributor
ACK
- laanwj referenced this in commit bcfd8590d2 on Mar 11, 2014
-
schildbach commented at 7:06 PM on March 12, 2014: contributor
Anything besides 2 ACKs and the mercy of pull tester needed to get this merged? I'm not familiar with the process.
- gavinandresen referenced this in commit ca0b8acbf3 on Mar 12, 2014
- gavinandresen merged this on Mar 12, 2014
- gavinandresen closed this on Mar 12, 2014
-
laanwj commented at 7:56 PM on March 12, 2014: member
@schildbach I thought I merged it, it seems something went wrong and it ended up in a feature branch instead.
- schildbach deleted the branch on Mar 23, 2014
- DrahtBot locked this on Sep 8, 2021
