qt: Make it possible again to specify -testnet in config file #3844

1. 
   laanwj commented at 7:40 am on March 11, 2014: member

   Changes for the datadir chooser have made it impossible to specify the network (testnet/regtest) in the configuration file for the GUI.

   Reorganize the initialization sequence to make this possible again.

   • Moves the “datadir” QSetting so that is no longer dependent on the network-specific application name (doing otherwise would create a chicken-and-egg problem).
   • Re-initialize translations after choosing network. There may be a different language configured in network-specific settings (slim chance, but handle it for sanity).

   Fixes point 1 of #3840.

2. qt: Make it possible again to specify -testnet in config file

   Changes for the datadir chooser have made it impossible to specify
   the network (testnet/regtest) in the configuration file for the GUI.
   
   Reorganize the initialization sequence to make this possible again.
   
   - Moves the "datadir" QSetting so that is no longer dependent on the
     network-specific application name (doing otherwise would create a
     chicken-and-egg problem).
   
   - Re-initialize translations after choosing network. There may be a
     different language configured in network-specific settings
     (slim chance, but handle it for sanity).
   
   Fixes point 1 of #3840.

   c52c4e5d14
3. 
   laanwj commented at 7:46 am on March 11, 2014: member

   This needs some testing:

   1. Set -testnet/-regtest on command line
   2. Set -testnet/-regtest in configuration file in data directory
   3. Specify both -testnet and -regtest: Does error message still work?
   4. Check with mainnet URI and testnet URI
      • Do URIs still affect testnet/mainnet when launching
      • Are URIs sent to the right process if both testnet and mainnet is running?
   5. Translations: does the language configured in options still work? (check both for testnet and mainnet, with different languages)
   6. Does lang= configured on the command line or configuration file work?
4. 
   BitcoinPullTester commented at 8:08 am on March 11, 2014: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c52c4e5d14fb20a0abc6fdcf8601ae5a0626ddcf for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
5. 
   laanwj commented at 10:10 am on March 11, 2014: member

   1. ok, tried both -testnet and -regtest

   2. ok, tried both -testnet and -regtest, command line takes precedence as it should

   3. ok

   4. ok

      src/qt/bitcoin-qt bitcoin:mmuwJuLsbtryYiYBLa6gS5kambDodyaWL5 -> launches testnet src/qt/bitcoin-qt bitcoin:1CjPR7Z5ZSyWk6WtXvSFgkptmpoi4UM9BC -> launches mainnet src/qt/bitcoin-qt & src/qt/bitcoin-qt -testnet & src/qt/bitcoin-qt bitcoin:mmuwJuLsbtryYiYBLa6gS5kambDodyaWL5 -> opens in testnet src/qt/bitcoin-qt bitcoin:1CjPR7Z5ZSyWk6WtXvSFgkptmpoi4UM9BC -> opens in mainnet

   5. ok; set mainnet to Deutsch and testnet to Afrikaans in the Options, got “Bitcoin-Kern” and “Beursie” as expected after restart

   6. ok; set lang=nl from the command line as well as bitcoin.conf, this worked

   Edit: also verified that -choosedatadir still works and stores/retrieves the data directory correctly

6. laanwj added this to the milestone 0.9.0 on Mar 11, 2014
7. 
   gavinandresen commented at 1:41 pm on March 11, 2014: contributor

   ACK
8. laanwj referenced this in commit fbdf4e5efa on Mar 11, 2014
9. laanwj merged this on Mar 11, 2014
10. laanwj closed this on Mar 11, 2014

    ---

11. laanwj deleted the branch on Apr 9, 2014
12. DrahtBot locked this on Sep 8, 2021

Contributors
laanwj BitcoinPullTester gavinandresen