[Qt] add expert section to wallet tab in optionsdialog #3850

pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz8 changing 2 files +30 −31

cozz commented at 10:52 PM on March 11, 2014: contributor

...dialog

See title. I think its better to move the "confusing" spendZeroConfChange in an "Expert" tab. Coin control is misplaced in "Display" tab currently, in my opinion. So moving it too.
in src/qt/forms/optionsdialog.ui:None in 70c7eaf4e4 outdated
```
 448 | @@ -469,17 +449,57 @@
 449 |          </widget>
 450 |         </item>
 451 |         <item>
 452 | +        <spacer name="verticalSpacer_Display">
```
Diapolo commented at 12:35 PM on March 12, 2014:

Be carefull to not dup names, you can try to just use verticalSpacer perhaps.

cozz commented at 1:28 PM on March 12, 2014:

I have not dup names. This is just git diff. verticalSpacer_Display gets removed below and added here:)
laanwj commented at 9:19 AM on March 17, 2014: member

I think we should have an 'expert' section in the Wallet tab, and move these options there.

At least personally I don't like 'Expert' as a category in itself, it's not descriptive.
cozz commented at 11:11 AM on March 17, 2014: contributor

Ok, so closing this. I will keep the expert section in the wallet tab in mind.
cozz closed this on Mar 17, 2014
laanwj commented at 11:27 AM on March 17, 2014: member

Another way that would be ok to me is the other way around; keep this Expert tab and create a Wallet category there.
cozz commented at 1:31 PM on March 17, 2014: contributor

@laanwj What do you think? Moved the description for spendzeroconfchange to tooltip.
laanwj commented at 6:58 AM on March 18, 2014: member

Looks good!
[Qt] add expert section to wallet tab in optionsdialog 16d281ba84
cozz renamed this:
~~[Qt] move spendzeroconfchange and coincontrol to "Expert" tab in options...~~
[Qt] add expert section to wallet tab in optionsdialog
on Mar 18, 2014
cozz commented at 12:54 PM on March 18, 2014: contributor

updated to "add expert section to wallet tab in optionsdialog"
cozz reopened this on Mar 18, 2014
BitcoinPullTester commented at 9:27 PM on March 18, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/16d281ba8411eda112777a2636ad499709324fa3 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit be0afe238b on Mar 21, 2014
laanwj merged this on Mar 21, 2014
laanwj closed this on Mar 21, 2014
DrahtBot locked this on Sep 8, 2021

Contributors