Update Boost docs for unix #3857

pull zander wants to merge 1 commits into bitcoin:0.9.0 from zander:increaseBoostVersion changing 1 files +7 −7

zander commented at 10:25 PM on March 12, 2014: none

Since my last update a week ago boost 1.54 no longer compiles with bitcoin (boost/atomic/atomic.hpp:202:16: error: ‘uintptr_t’ was not declared in this scope) Included from alert.cpp.

Upgrading to 1.55 works on my debian testing (jessy) machine. This updates the docs of the minimum required version.

Notice that maybe the configure.ac should be adjusted too, I just don't know that language.

Incidentally; this also fixes bug #3755
luke-jr commented at 10:29 PM on March 12, 2014: member

Better to workaround for now.
laanwj commented at 10:08 AM on March 13, 2014: member

This should definitely be worked around. Requiring boost 1.55 is not acceptable IMO.
Update docs about boost on unix ad5dec8977

in doc/build-unix.md:None in c5cf5c06f6 outdated

  45 | @@ -46,7 +46,7 @@ Licenses of statically linked libraries:
  46 |  -  GCC           4.3.3
  47 |  -  OpenSSL       1.0.1c
  48 |  -  Berkeley DB   4.8.30.NC
  49 | --  Boost         1.37
  50 | +-  Boost         1.55

laanwj commented at 3:19 PM on March 13, 2014:

ACK on this line

in doc/build-unix.md:None in c5cf5c06f6 outdated

  85 | @@ -91,8 +86,7 @@ for other Ubuntu & Debian:
  86 |  
  87 |  	sudo apt-get install libdb4.8-dev
  88 |  	sudo apt-get install libdb4.8++-dev
  89 | -	sudo apt-get install libboost1.37-dev
  90 | - (If using Boost 1.37, append -mt to the boost libraries in the makefile)
  91 | +	sudo apt-get install libboost1.55-all-dev

laanwj commented at 3:20 PM on March 13, 2014:

ACK on this as well. Boost 1.37 is ancient. Though which boost version is available exactly depends on the distribution...

zander commented at 5:28 PM on March 13, 2014: none

I'm not sure how to work around the issue, but I cleaned up the commit as a simple docs commit so its hopefully mergable anyway.

Additionally, it seems my initial assesment was wrong, this compile issue was not due to any change in bitcoin. I failed to compile even various months old versions of the 0.9.0 branch against boost1.54. The issue is certainly not a showstopper AFAICT.
laanwj commented at 6:47 AM on March 14, 2014: member

ACK on new changes
laanwj commented at 12:24 PM on March 14, 2014: member

Cherry-picked into 0.9.0 and master (b233b8a and 6603b09)
laanwj closed this on Mar 14, 2014
zander deleted the branch on Dec 28, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

zander

luke-jr

laanwj

Linked (view graph)

#3755 doc/build-unix.md asks for install of debian package which does not exist, libboost1.37-dev