Four years looks slightly nicer than 208 weeks.
Closes #3811.
qt: Show weeks as well as years behind for long timespans #3876
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_03_qt_years_weeks_behind changing 2 files +28 −5-
laanwj commented at 9:18 AM on March 15, 2014: member
-
a1465ac8e6
qt: Show weeks as well as years behind for long timespans
Closes #3811.
-
felipelalli commented at 10:24 AM on March 15, 2014: none
ship it!
-
laanwj commented at 10:26 AM on March 15, 2014: member
Have you tested?
-
felipelalli commented at 10:31 AM on March 15, 2014: none
No, I am sorry. Just code review. I am setting up the environment to start to contribute. I am reading all READMEs, and I read that I can contribute with code review and also test, which is the current bottleneck. Should I test carefully every change before send a "ship it"? Even theses small changes? Thank you for help.
-
laanwj commented at 10:36 AM on March 15, 2014: member
Nah, it's not super important in this case. I ask just in case, I usually feel better merging something when someone else has at least tested it (even minor changes like this). Thanks for trying to contribute!
-
felipelalli commented at 10:46 AM on March 15, 2014: none
Thank you @laanwj ! I hope to get everything over time.
-
haakonn commented at 1:36 PM on March 15, 2014: contributor
ACK.
I tested this using 'bitcoin-qt --reindex' under Qt4/Ubuntu. Seems to work as advertised, and I really like it! The only change that arguably could be an improvement would be to simplify "3 years and 0 weeks behind" to simply "3 years behind". But that's a minor thing and I think this is mergeable as is.
- laanwj referenced this in commit cb0c42e7da on Mar 15, 2014
- laanwj merged this on Mar 15, 2014
- laanwj closed this on Mar 15, 2014
- laanwj deleted the branch on Apr 9, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors