Function should return true in case of success, currently returns nothing. This trivial patch fixes that.
CKeyStore::AddKey must return a boolean #389
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:addkey_retval changing 1 files +1 −0-
laanwj commented at 1:16 PM on July 7, 2011: member
-
CKeyStore::AddKey must return a boolean 33c75fd9aa
-
sipa commented at 1:29 PM on July 7, 2011: member
This should have been fixed before indeed, it's only fixed in Matt's encryption branch (newenc) now.
Also, it's not a problem as CKeyStore::AddKey() is masked by CWallet::AddKey(), which ignores the other one's result.
If we weren't in -rc3 already, I'd ACK.
-
jgarzik commented at 2:14 AM on July 13, 2011: contributor
pulled wallet crypto, so, superceded
- jgarzik closed this on Jul 13, 2011
- laanwj referenced this in commit 0ffb3bd95f on Aug 4, 2016
- laanwj referenced this in commit b2135359b3 on Aug 16, 2016
- MarcoFalke referenced this in commit 64dfdde0aa on Dec 13, 2016
- deadalnix referenced this in commit 2c52b5d244 on Jan 19, 2017
- lateminer referenced this in commit 5a8e2ad20d on Oct 16, 2019
- rajarshimaitra referenced this in commit 9e2530356c on Aug 5, 2021
- DrahtBot locked this on Sep 8, 2021
