Unparseable scripts in BIP70 payment requests #3900

issue schildbach opened this issue on March 19, 2014

schildbach commented at 2:36 PM on March 19, 2014: contributor

While investigating a ScriptException in bitcoinj caused by a user supplied BIP70 payment request, it turned out that the user had put a base58 address directly into the script field in the Output protobuf, rather than a pay-to-address script.

Bitcoin Core 0.9.0rc2 accepts this and if I pay, I end up with a transaction without "to address" in my transactions list. While I'm aware its the obligation of the payee to supply a valid script, I'd argue it should at least be checked if the field can be parsed as a script. At least the spec tells it should be a "TxOut" script.
schildbach renamed this:
~~Invalid scripts in BIP70 payment requests~~
Unparseable scripts in BIP70 payment requests
on Mar 19, 2014
schildbach commented at 2:44 PM on March 19, 2014: contributor

Btw. here is the transaction I created: https://www.biteasy.com/testnet/transactions/1c7139d9afc0f46b1b8629d710e59112af32d69382913a267685ec0b3c01058b

I assume on mainnet it would never confirm.
gavinandresen commented at 3:30 PM on March 19, 2014: contributor

It would be rejected as a non-standard transaction on mainnet -- but it would be great to extend https://github.com/gavinandresen/paymentrequest/tree/master/php so there is an easy way to test that.
schildbach commented at 10:28 PM on March 19, 2014: contributor

I can upload or e-mail a paymentrequest that demos the issue. I'm afraid I can't code PHP.
laanwj added the label GUI on May 13, 2014
meshcollider commented at 8:31 PM on March 11, 2018: contributor

Is this still an issue in more recent versions of core?
jnewbery commented at 9:05 PM on April 2, 2018: member

No response. Closing for now.

If it turns out that this is still an issue, we can re-open.
jnewbery closed this on Apr 2, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels