Add Andreas Schildbach to gitian download scripts. #3907

pull schildbach wants to merge 2 commits into bitcoin:master from schildbach:gitian-downloader-aschildbach-key changing 3 files +6 −20

schildbach commented at 9:00 PM on March 19, 2014: contributor

No description provided.
in contrib/gitian-downloader/linux-download-config:None in 70d2c8bb32 outdated
```
  42 | @@ -43,4 +43,8 @@ signers:
  43 |      weight: 1
  44 |      name: michagogo
  45 |      key: michagogo
  46 | +  E944AE667CF960B1004BC32FCA662BE18B877A60:
  47 | +    weight: 40
```
laanwj commented at 7:37 AM on March 20, 2014:

What should this weight be? Why michagogo only has 1?

schildbach commented at 7:44 AM on March 20, 2014:

I asked on the mailing list and they said weight is added up until minimum_weight reached (which means the download is verified). As for the michagogo question, I don't know.

Michagogo commented at 11:29 AM on March 21, 2014:

The relevant PR is #3023, most of the discussion re: weight can be found in the IRC logs, if you want to go back and find it.
schildbach commented at 11:15 AM on March 29, 2014: contributor

Ping! What's needed/missing to get this merged?
laanwj commented at 11:24 AM on March 29, 2014: member

Nothing missing IMO, but I am waiting for someone else from the core devs to comment on the weight issue (I think michagogo 1 versus the rest 40 makes no sense).
sipa commented at 4:20 PM on March 29, 2014: member

This isn't actually used in any way right now. Maybe we want to postpone the weights discussion until an actual downloader is ready and being deployed?
schildbach commented at 4:26 PM on March 29, 2014: contributor

So can you just tell me what the weight should be for now?
sipa commented at 4:42 PM on March 29, 2014: member

I don't care. It has no meaning.
laanwj commented at 5:02 PM on March 29, 2014: member

If we want to postpone the discussion, I'd vote for removing the weights. This is bound to come back every time otherwise.
Michagogo commented at 5:38 PM on March 29, 2014: contributor

Or set them all to 11? :-P

On Saturday, March 29, 2014, Wladimir J. van der Laan < notifications@github.com> wrote:

If we want to postpone the discussion, I'd vote for removing the weights.

— Reply to this email directly or view it on GitHubhttps://github.com/bitcoin/bitcoin/pull/3907#issuecomment-39001653 .
laanwj commented at 6:01 PM on March 29, 2014: member

Yes, let's do that :)
Add Andreas Schildbach to gitian download scripts. 5d433613e2
Remove weights from download config for now as it's unclear how it will be used in future. 2a9edeb1c8
schildbach commented at 12:26 PM on March 30, 2014: contributor

I put a commit on top that removes all weights from the download config. Now you can pick merging either only the first commit or merging both.
BitcoinPullTester commented at 12:44 PM on March 30, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/2a9edeb1c8447397dc9b05843e179379ad922dfc for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Michagogo commented at 1:47 PM on March 30, 2014: contributor

Okay, at this point I have a question. What is the point of contrib/gitian-downloader existing with the configs at all if we're not using them? I'm assuming that @aschildbach's latest change makes the file's syntax or w/e invalid. What's the point of keeping it at all?
laanwj referenced this in commit b725af7599 on Mar 30, 2014
laanwj merged this on Mar 30, 2014
laanwj closed this on Mar 30, 2014
schildbach deleted the branch on Mar 30, 2014
sidhujag referenced this in commit 4fda37eaaf on Jan 11, 2021
DrahtBot locked this on Sep 8, 2021

Contributors