[Qt] Fix enable/disable show and remove buttons #3927

pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz8 changing 1 files +5 −4

cozz commented at 3:35 PM on March 21, 2014: contributor

Since the column resizer commit, the show and remove buttons are always disabled. Moving the connect seems to fix the problem. Resizing still works.
laanwj commented at 4:00 PM on March 21, 2014: member

Indeed, good catch. setModel() replaces the selection model as well, so connecting it before setting the model is pointless.
[Qt] Fix enable/disable show and remove buttons ab1edd44d8

in src/qt/receivecoinsdialog.cpp:None in 71f77ab370 outdated

  77 | @@ -82,6 +78,11 @@ void ReceiveCoinsDialog::setModel(WalletModel *model)
  78 |          tableView->setColumnWidth(RecentRequestsTableModel::Date, DATE_COLUMN_WIDTH);
  79 |          tableView->setColumnWidth(RecentRequestsTableModel::Label, LABEL_COLUMN_WIDTH);
  80 |  
  81 | +        connect(ui->recentRequestsView->selectionModel(),

laanwj commented at 4:00 PM on March 21, 2014:

You could use tableView->... here, slightly shorter

laanwj commented at 4:24 PM on March 21, 2014: member

ACK
BitcoinPullTester commented at 5:04 PM on March 21, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ab1edd44d83a0e710d9d41471399c417ede0b0bd for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit d3c3210fa3 on Mar 23, 2014
laanwj merged this on Mar 23, 2014
laanwj closed this on Mar 23, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

cozz

laanwj

BitcoinPullTester