RPC command getmininginfo showing right genproclimit #3931

pull isghe wants to merge 1 commits into bitcoin:master from isghe:getmininginfo_genproclimit changing 1 files +1 −0

isghe commented at 10:12 PM on March 21, 2014: contributor

With tag version v0.9.0, getmininginfo was showing always genproclimit -1. $ ./bitcoind setgenerate true 1 $ ./bitcoind getmininginfo { ... "genproclimit" : -1, ... }

with this patch, now it is showing the right value: $ ./bitcoind setgenerate true 1 $ ./bitcoind getmininginfo { ... "genproclimit" : 1, ... }

in src/rpcmining.cpp:None in 156567a022 outdated

 203 | @@ -204,6 +204,11 @@ Value setgenerate(const Array& params, bool fHelp)
 204 |      else // Not -regtest: start generate thread, return immediately
 205 |      {
 206 |          mapArgs["-gen"] = (fGenerate ? "1" : "0");
 207 | +        {
 208 | +            std::stringstream ss;
 209 | +            ss << nGenProcLimit;
 210 | +            mapArgs ["-genproclimit"] = ss.str ();
 211 | +        }

laanwj commented at 7:05 AM on March 22, 2014:

Please use

mapArgs ["-genproclimit"] = itostr(nGenProcLimit);

laanwj commented at 1:39 PM on March 22, 2014: member

ACK after squishing into one commit
RPC command getmininginfo showing right genproclimit f61287c9b1
isghe commented at 3:05 PM on March 22, 2014: contributor

done: squashed in one commit
BitcoinPullTester commented at 3:32 PM on March 22, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/f61287c9b15ff665761bf2aa71646fe55e90cbbc for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 397521d632 on Apr 1, 2014
laanwj merged this on Apr 1, 2014
laanwj closed this on Apr 1, 2014
isghe deleted the branch on Aug 11, 2018
DrahtBot locked this on Sep 8, 2021

Contributors

isghe

laanwj

BitcoinPullTester