qt: Do proper boost::path conversion #3935

1. 
   laanwj commented at 9:55 am on March 22, 2014: member

   Convert from QString unicode from/to the OS-dependent locale as used by boost::filesystem::path as needed.

   This should make data directories with special characters in Windows work.

   Should solve #3916 and #3905.

   Test builds (windows) can be found here: https://download.visucore.com/bitcoin/bitcoin-2014_03_qt_unicode_path_v3.zip Signature: https://download.visucore.com/bitcoin/bitcoin-2014_03_qt_unicode_path_v3.zip.sig

2. 
   laanwj commented at 10:37 am on March 22, 2014: member

   Seems the appropriate conversion function don’t even exist yet in the boost used by the pulltester.

   0guiutil.cpp:36:58: error: boost/filesystem/detail/utf8_codecvt_facet.hpp: No such file or directory
   1guiutil.cpp:58: error: ‘utf8_codecvt_facet’ in namespace ‘boost::filesystem::detail’ does not name a type
   

   Probably needs some boost::filesystem version #ifdefs…

3. qt: Do proper boost::path conversion

   Convert from QString unicode from/to the OS-dependent locale
   as used by boost::filesystem::path as needed.
   
   Solves #3916.

   7e591c19e7
4. qt: Only override -datadir if different from the default

   Fixes #3905.

   c61fe44194
5. 
   BitcoinPullTester commented at 8:46 am on March 25, 2014: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c61fe44194ea6d549adfe9ae944ce6fa3a467e0f for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
6. laanwj referenced this in commit f284b5998a on Mar 26, 2014
7. laanwj merged this on Mar 26, 2014
8. laanwj closed this on Mar 26, 2014

   ---

9. laanwj deleted the branch on Apr 9, 2014
10. DrahtBot locked this on Sep 8, 2021

Contributors
laanwj BitcoinPullTester