Use sensible categories (overall control, P2P, blockchain/UTXO, mining, utils, wallet, wallet-enabled mining) and sort within each.
validateaddress was wrongly categorized under 'Mining'.
Also remove unnecessary #ifdef ENABLE_WALLET from rpcnet.cpp.
Functionality-neutral change (a way to display the categories in "help" would be nice as well, but is not covered in this pull).
ACK
It seems we're heading towards two separate classifications (one functionality-based and mostly what the file organization of rpc*.cpp looks like, another dependency-based like here). Do we want to head towards a single one?
Things like the raw transaction API are hard, as together they provide a single functionality, but the dependency/module interactions of the separate RPCs is very different.
Well IMO the only functions that are problematic are the functions that optionally use the wallet, as they make it impossible to do a clean split between the wallet and node functionality. I don't mind what functions end up in what category and if you have a better proposal that's great.
BTW: welcome back @alexwaters!
No, no better proposal. I'm fine with either functionality-based or dependency-based, but we should do it consistently (meaning, that's also how the rpc methods should be organized into files).
Agreed. Well, I'll move the "raw transactions API" calls (at least those that are available without wallet) to their own category, I think that's a good idea.
Use sensible categories (overall control, P2P, blockchain/UTXO and
mining, wallet, wallet-enabled mining) and sort within each.
Also remove unnecessary #ifdef ENABLE_WALLET from `rpcnet.cpp`.
Functionality-neutral change.
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/acddef1a902265e3fa401bb4b0597661383214c2 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.