Adjust high nTransactionFee warning to reflect market prices. #3969

pull bardiharborow wants to merge 1 commits into bitcoin:master from bardiharborow:master changing 2 files +4 −1

bardiharborow commented at 1:06 AM on March 28, 2014: contributor

The 0.25BTC -paytxfee warning has been there since at least commit 7d80d2e3d7ecceb5a99fef357b118949f6dd8a79 in 2012. In line with new market prices, I've adjusted it to 0.01BTC or $4.75USD at time of writing.
laanwj commented at 8:37 AM on March 28, 2014: member

ACK
bardiharborow commented at 9:19 AM on March 28, 2014: contributor

@laanwj, for my information, what does ACK mean?
laanwj commented at 9:22 AM on March 28, 2014: member

"accepted for merge" (in my opinion)
ghost commented at 10:43 AM on March 28, 2014: none

ACK

in src/init.cpp:None in 5cc32b52ab outdated

 574 | @@ -575,7 +575,7 @@ bool AppInit2(boost::thread_group& threadGroup)
 575 |      {
 576 |          if (!ParseMoney(mapArgs["-paytxfee"], nTransactionFee))
 577 |              return InitError(strprintf(_("Invalid amount for -paytxfee=<amount>: '%s'"), mapArgs["-paytxfee"]));
 578 | -        if (nTransactionFee > 0.25 * COIN)
 579 | +        if (nTransactionFee > 0.01 * COIN)

Diapolo commented at 11:05 AM on March 28, 2014:

Could this perhaps be a constant in an obvious place, that we update from time to time?

laanwj commented at 11:20 AM on March 28, 2014:

Good point. This should be a constant in wallet.h.

bardiharborow commented at 1:11 AM on March 29, 2014: contributor

@laanwj, I've pushed a rebased replacement commit as per @Diapolo and your suggestion.
Add nHighTransactionFeeWarning as per #3969. ffeb47366d

in src/wallet.h:None in 4e4c8bc300 outdated

  24 | @@ -25,6 +25,7 @@
  25 |  
  26 |  // Settings
  27 |  extern int64_t nTransactionFee;
  28 | +int nHighTransactionFeeWarning;

laanwj commented at 9:10 AM on March 29, 2014:

I'd prefer

// -paytxfee will warn of more fee than this amount (in satoshis) per KB
static const int nHighTransactionFeeWarning = 0.01 * COIN;

No changes to wallet.cpp needed

bardiharborow commented at 9:19 AM on March 29, 2014: contributor

@laanwj, Ok, will that work? Sorry for my incompetence with C++.
BitcoinPullTester commented at 9:50 AM on March 29, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ffeb47366df02b7f859ce3e64f2304967c837e8e for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 10:37 AM on March 29, 2014: member

Yeah no problem we all had to learn at some point...
sipa commented at 4:22 PM on March 29, 2014: member

ACK
leofidus commented at 7:20 PM on March 29, 2014: none

ACK from me, if that counts for anything
laanwj referenced this in commit b86ed6ff23 on Mar 31, 2014
laanwj merged this on Mar 31, 2014
laanwj closed this on Mar 31, 2014
MathyV referenced this in commit 1b2a9031a7 on Oct 27, 2014
DrahtBot locked this on Sep 8, 2021

Contributors