Units in transaction export csv file #3970

The transaction Export function appears to output bitcoin in the same units as selected in settings (BTC/mBTC/uBTC.) and displayed on the transaction listing, but there is no indication of what unit is used in the csv file. Either the cvs file should output in btc or the units used needs to appear in the file.

Yes, the unit should be in the table header.

The issue comes from the fact that the export system exports from the qt table, not from the underlying data source, so whatever is displayed on the table is outputted. See src/qt/csvmodelwriter.cpp. If we were to specify the units in the table header, they would be included in the .cvs file. Not sure how to do that though. Still researching, I'll get back to you.

This just needs writer.addColumn(tr("Amount"), 0, TransactionTableModel::FormattedAmountRole); changing in src/qt/transactionview.cpp.

I'm not entirely sure on the best way of including the unit maybe: BitcoinUnits::name(model->getOptionsModel()->getDisplayUnit())

Yeah, something like

if (!model->getOptionsModel())  /* add null pointer check */
    return;
...
writer.addColumn(tr("Amount") + " [" + BitcoinUnits::name(model->getOptionsModel()->getDisplayUnit()) + "]", 0, TransactionTableModel::FormattedAmountRole);

I've gone ahead and added this to the amount column both here on the export writer, as well as on the columns of the recent transaction and recent payment request UI tables as part of a patch I'll be submitting soon.

Fixed by #4302