Bitcoin Core GUI fails to build with --disable-wallet #3978

issue luke-jr opened this issue on March 29, 2014

luke-jr commented at 4:18 AM on March 29, 2014: member

Either it should build (and be useless? dunno), or configure should reject --disable-wallet with an error.
laanwj commented at 4:46 AM on March 29, 2014: member

This worked with the 0.9.0 release. The 'node' GUI is not quite useless, it shows the debug console, the number of connections etc. This probably broke with a recent commit. What does it fail on?
luke-jr commented at 4:49 AM on March 29, 2014: member

I was testing with the v0.9.0 tag.
laanwj commented at 4:51 AM on March 29, 2014: member

OK never mind, I do know that it worked at some point.

Maybe we should make pulltester also test the --disable-wallet mode.

luke-jr commented at 4:51 AM on March 29, 2014: member

In file included from ../../src/walletdb.h:8:0,
                 from ../../src/wallet.h:15,
                 from bitcoin.cpp:28:
../../src/db.h:18:20: fatal error: db_cxx.h: No such file or directory

laanwj commented at 4:55 AM on March 29, 2014: member

Ah, there is a hiddden BDB dependency. I never noticed that because I never tried building with GUI on a system without BDB.

That #include "wallet.h" should be in a #ifdef ENABLE_WALLET.
laanwj referenced this in commit 65adc3a893 on Mar 31, 2014
laanwj closed this on Apr 1, 2014
MathyV referenced this in commit 08f9288249 on Oct 27, 2014
MarcoFalke locked this on Sep 8, 2021

Contributors

luke-jr

laanwj

Linked (view graph)

#3986 Small build and doc improvements