Remove ‘ProcessBlock: ACCEPTED’ messages #3984

1. 
   rebroad commented at 0:51 am on March 31, 2014: contributor

   I think this line could be removed, so that this:

   2014-03-30 16:52:57 received block 000000000000000055fd58a596c921f789b3785c0e84242f87981f7762117f73 node=1 2014-03-30 16:52:59 UpdateTip: new best=000000000000000055fd58a596c921f789b3785c0e84242f87981f7762117f73 height=292899 log2_work=77.586222 tx=35771262 date=2014-03-28 11:46:26 progress=0.988418 2014-03-30 16:52:59 ProcessBlock: ACCEPTED 2014-03-30 16:53:02 received block 00000000000000001544a7fce213d98be118f550c792624758d2015165d003ab node=1 2014-03-30 16:53:04 UpdateTip: new best=00000000000000001544a7fce213d98be118f550c792624758d2015165d003ab height=292900 log2_work=77.586358 tx=35771641 date=2014-03-28 11:51:47 progress=0.988438 2014-03-30 16:53:04 ProcessBlock: ACCEPTED 2014-03-30 16:53:05 received block 0000000000000000475115027af8b17991c8c5ed424f08472c7518cbd524a9fa node=1 2014-03-30 16:53:06 UpdateTip: new best=0000000000000000475115027af8b17991c8c5ed424f08472c7518cbd524a9fa height=292901 log2_work=77.586495 tx=35771875 date=2014-03-28 11:56:48 progress=0.988456 2014-03-30 16:53:06 ProcessBlock: ACCEPTED 2014-03-30 16:53:09 received block 0000000000000000da52112a8558dc772049eee77a0a6f3fddfdebfda18ed36b node=1 2014-03-30 16:53:10 UpdateTip: new best=0000000000000000da52112a8558dc772049eee77a0a6f3fddfdebfda18ed36b height=292902 log2_work=77.586632 tx=35772180 date=2014-03-28 12:03:23 progress=0.988480 2014-03-30 16:53:10 ProcessBlock: ACCEPTED

   becomes this:-

   2014-03-30 16:52:57 received block 000000000000000055fd58a596c921f789b3785c0e84242f87981f7762117f73 node=1 2014-03-30 16:52:59 UpdateTip: new best=000000000000000055fd58a596c921f789b3785c0e84242f87981f7762117f73 height=292899 log2_work=77.586222 tx=35771262 date=2014-03-28 11:46:26 progress=0.988418 2014-03-30 16:53:02 received block 00000000000000001544a7fce213d98be118f550c792624758d2015165d003ab node=1 2014-03-30 16:53:04 UpdateTip: new best=00000000000000001544a7fce213d98be118f550c792624758d2015165d003ab height=292900 log2_work=77.586358 tx=35771641 date=2014-03-28 11:51:47 progress=0.988438 2014-03-30 16:53:05 received block 0000000000000000475115027af8b17991c8c5ed424f08472c7518cbd524a9fa node=1 2014-03-30 16:53:06 UpdateTip: new best=0000000000000000475115027af8b17991c8c5ed424f08472c7518cbd524a9fa height=292901 log2_work=77.586495 tx=35771875 date=2014-03-28 11:56:48 progress=0.988456 2014-03-30 16:53:09 received block 0000000000000000da52112a8558dc772049eee77a0a6f3fddfdebfda18ed36b node=1 2014-03-30 16:53:10 UpdateTip: new best=0000000000000000da52112a8558dc772049eee77a0a6f3fddfdebfda18ed36b height=292902 log2_work=77.586632 tx=35772180 date=2014-03-28 12:03:23 progress=0.988480

   We know a ProcessBlock is accepted when we see a new Updated Tip or Orphan block added, and if it fails we see an error message, so the line is kinda redundant.

2. Remove 'ProcessBlock: ACCEPTED' messages 7ce253a8b8
3. 
   bardiharborow commented at 0:58 am on March 31, 2014: contributor

   NACK. It is there as a very low level debug measure. If the code is operating normally then we don’t even need to look at the debug.log. If for example something is stopping the accept but the code does not fail properly, then it helps us.
4. 
   BitcoinPullTester commented at 1:23 am on March 31, 2014: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7ce253a8b841f62ac6a34499bea45c6c505b0ace for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
5. 
   laanwj commented at 2:37 am on March 31, 2014: member

   NACK. It’s useful for debugging to know when ProcessBlock is finished, as it seems to take a long time sometimes.
6. 
   rebroad commented at 5:09 pm on March 31, 2014: contributor

   @laanwj How about if i change this patch so that it’s displayed only when it takes a long time (and include the duration with the message)?
7. 
   laanwj commented at 6:26 am on April 1, 2014: member

   No, let’s just leave it as it is. It’s easy enough to see the duration of events by the difference in timestamp. Let’s try to fix issues instead of discussing about debug log messages…
8. laanwj closed this on Apr 1, 2014

   ---

9. DrahtBot locked this on Sep 8, 2021

Contributors
rebroad bardiharborow BitcoinPullTester laanwj