add benchmark for block/undo file reading/writing #4001

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:bench_block changing 2 files +25 −5

Diapolo commented at 8:41 AM on April 4, 2014: none

No description provided.
add benchmark for block/undo file reading/writing e21efd5de0
Diapolo commented at 1:21 PM on May 20, 2014: none

@sipa Any thoughts?
Diapolo commented at 9:35 AM on May 29, 2014: none

@sipa Ping :)
sipa commented at 10:27 AM on May 29, 2014: member

ACK
sipa commented at 11:41 AM on June 1, 2014: member

This is very spammy though, compared to normal -benchmark...
Diapolo commented at 4:38 PM on June 2, 2014: none

@sipa Many blocks, many entries in debug.log, yes... what do you suggest?
laanwj commented at 8:48 AM on June 10, 2014: member

I don't know, maybe add a specific benchmark option for this?
BitcoinPullTester commented at 1:19 PM on June 23, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4001_e21efd5de061cd005385932d3058b79323e4b217/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 3:59 PM on June 24, 2014: member

I'm not convinced of the need of adding per-function benchmark functionality to bitcoind. In principle the same (and better) could be done with a profiler.
Diapolo commented at 9:04 AM on June 27, 2014: none

@sipa If you agree @laanwj you are free to just close this, so we can go on :).
sipa commented at 11:51 AM on June 27, 2014: member

Yeah, I think there's little benefit here.
Diapolo closed this on Jun 27, 2014
Diapolo deleted the branch on Jun 27, 2014
DrahtBot locked this on Sep 8, 2021

Contributors