configure.ac: INCLUDES to AM_CPPFLAGS #4008

pull isghe wants to merge 1 commits into bitcoin:master from isghe:configure_AM_CPPFLAGS changing 1 files +1 −1

isghe commented at 7:46 PM on April 5, 2014: contributor

to avoid: $ ./autogen.sh configure.ac:712: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '__CPPFLAGS') configure.ac:712: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '__CPPFLAGS') configure.ac:712: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '__CPPFLAGS') configure.ac:712: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '__CPPFLAGS') configure.ac:712: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')

http://www.gnu.org/software/automake/manual/html_node/Program-Variables.html INCLUDES: This variable is deprecated; we suggest using AM_CPPFLAGS and per-target _CPPFLAGS instead.

configure.ac: INCLUDES to AM_CPPFLAGS

to avoid:
$ ./autogen.sh
configure.ac:712: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
configure.ac:712: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
configure.ac:712: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
configure.ac:712: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
configure.ac:712: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')

http://www.gnu.org/software/automake/manual/html_node/Program-Variables.html
INCLUDES: This variable is deprecated; we suggest using AM_CPPFLAGS and per-target _CPPFLAGS instead.

33d4079df7

isghe commented at 7:47 PM on April 5, 2014: contributor

Tested only on OS X 10.9.2
BitcoinPullTester commented at 8:03 PM on April 5, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/33d4079df7490029d57e63d58cfd6cacf52fe51c for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 8:19 AM on April 7, 2014: member

You need to make sure that you also change around all the uses of INCLUDES in configure.ac as well as the source files in src/m4 and the makefile.ams.
laanwj commented at 11:06 AM on April 18, 2014: member

Closing this. As mentioned above, it is not correct in its current state.

Let me know if you fix this so it can be reopened, or create a new pull.
laanwj closed this on Apr 18, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

isghe

BitcoinPullTester

laanwj