Added new constant to represent the desirable minimum remainder to leave in spent transactions, where change is required. Added comments to coin selection code to clarify process.
Make semantics of coin choosing algorithm clearer #4052
pull rnicoll wants to merge 1 commits into bitcoin:master from rnicoll:master-select-coins changing 2 files +12 −4-
rnicoll commented at 1:22 PM on April 13, 2014: contributor
-
192722e8c1
Added new constant to represent the desirable minimum remainder to leave in spent
transactions, where change is required. Added comments to coin selection code to clarify process.
-
BitcoinPullTester commented at 2:07 PM on April 13, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/192722e8c1075ec834fc0b04e5cba8e9dc5d2265 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
gavinandresen commented at 12:47 AM on April 14, 2014: contributor
I'm working on a pull request that removes the CENT-related rule.
-
rnicoll commented at 10:49 AM on April 17, 2014: contributor
Closing this given the code is to be replaced anyway. Thanks for feedback everyone.
- rnicoll closed this on Apr 17, 2014
-
laanwj commented at 11:08 AM on April 17, 2014: member
It's safe to say that all code will be eventually replaced.
It depends on the time frame whether it makes sense to merge this or not. In general I'm very much in favor of pulls that improve documentation in the code.
-
rnicoll commented at 12:37 PM on April 17, 2014: contributor
I'm inferring that's an imminent PR, but obviously very happy to re-open if not!
- rnicoll deleted the branch on Aug 29, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors