Pointed to location of BDB 4.8 in procedure for unix build. #4063

No description provided.

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/62d42dad35b507f2896e240ff82abdb2c9569b6e for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

Looks good.

For paranoia mode you could add:

echo '12edc0df75bf9abd7f82f821795bcee50f42cb2e5f76a6a281b85732798364ef  db-4.8.30.NC.tar.gz' | sha256sum -c
# -> db-4.8.30.NC.tar.gz: OK

Ha! That's clever! If you want it done I'll do it, let me know. Your call, you're the man. The drawback could be that if you do this once, you set the precedent and have to do it in other places.

Congratulations on your new position BTW. Things are running very well and we all appreciate it.

Thank you!

In other places it may not be needed because the input is verified. For example the gitian builder does exactly this check already. As the file is downloaded over http, it could be easy to patch in something nasty while underway.

I like the checksum, because the user experience while doing the build is "apt-get apt-get ok that's fine i'm safe apt-get" then suddenly you're downloading from another party. It is kind of odd - it confused me twice.

I haven't tried the other method because I didn't realize it was there, which says something. I should. I think its worthwhile to make the builds easier as time goes on to encourage the practice.

Yes, making the builds easier (or at least documenting better how to do it) would be good. Switching to autotools was a step in this direction.

Committed through 61d388d98ddd6d3fd521b6afbbb06209a6a50598