add a sed script to process libboost_chrono-mgw48-mt-s-1_55.dll.a, -e 's;^lib(boost_chrono.).dll.a.$;\1;'
Update ax_boost_chrono.m4 #4078
pull imwuzhh wants to merge 1 commits into bitcoin:master from imwuzhh:patch-2 changing 1 files +1 −1-
imwuzhh commented at 1:31 AM on April 21, 2014: contributor
-
6cb4487947
Update ax_boost_chrono.m4
Hi, i known building system works well now, but, when i am trying to link with dynamic boost libs on mingw on win7(yes, official propose building on linux with cross mingw tool), there is error. because m4 will let test script to link with -lboost_chrono_<somethingofversion>.dll, but my mingw32 on win7 does NOT work. after fix, it works. i see that, m4 also try to support .dylib suffix, although, the proposed way is to link with static boost libraries. so can you confirm and verify this fix, thanks!
-
BitcoinPullTester commented at 2:00 AM on April 21, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/6cb448794786d7383c07f6b3aa3b61c425918e79 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 11:53 AM on April 22, 2014: member
Can you please improve the commit message to specify what exactly you're changing here? It's one long line of shell code, and you're only explaining your rationale for making a change, not what you're changing.
- laanwj added the label Build system on May 28, 2014
-
-
theuni commented at 9:24 PM on May 28, 2014: member
I don't believe we're setup for shared linking of boost on win32 anyway. I tried to account for the possibility when writing the configure, but I never tested, so it's hard to believe it works. I'd rather not mess with upstream files (especially ones as nasty as these) without good cause. @imwuzhh Are you able to get a working build out of this? And if so, how do you benefit by using boost dll's?
-
imwuzhh commented at 1:04 AM on May 29, 2014: contributor
by accident, i linked bitcoind with dynamic boost, and this issue appear. but i agree with your original setting that link bitcoind with static boost, and it is a better way to build and deploy, so, if there is no plan to shared deploy, please ignore this pull request, Thanks.
in fact, i am now using the static version to develop too, :)
- laanwj closed this on May 29, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels