Unit tests failing with -DDEBUG_LOCKORDER #4084

issue gavinandresen opened this issue on April 22, 2014

gavinandresen commented at 7:59 PM on April 22, 2014: contributor

@laanwj : your new AssertLockHeld() assertions break unit tests. We should probably compile pull-tester unit-test binaries with -DDEBUG_LOCKORDER to catch these:

unknown location:0: fatal error in "test_IsStandard": signal: SIGABRT (application abort requested)
transaction_tests.cpp:274: last checkpoint
Assertion failed: lock cs_main not held in main.cpp:560; locks held:
pwalletMain->cs_wallet  rpc_wallet_tests.cpp:68

Fixing that, I ran into another:

script_P2SH_tests.cpp:182: last checkpoint
Assertion failed: lock cs_main not held in main.cpp:560; locks held:

(I haven't gone any further)

gavinandresen assigned laanwj on Apr 22, 2014
laanwj commented at 5:48 AM on April 23, 2014: member

Hm, interesting, I did run everything with DEBUG_LOCKORDER at some point (even the qa/rpc-tests).

Looking...

Edit: enabling DEBUG_LOCKORDER for the pulltester would make sense
laanwj commented at 6:23 AM on April 23, 2014: member

[ignore last post, this was in the wrong issue]
laanwj closed this on Apr 23, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

gavinandresen

laanwj

Linked (view graph)

#4085 Locking robustness fixes