[Qt] Optionally add third party links to transaction context menu #4092

pull cozz wants to merge 1 commits into bitcoin:master from cozz:cozz7 changing 8 files +87 −0

cozz commented at 12:17 AM on April 25, 2014: contributor

Adds the possibility to open a transaction in block explorer through right-click context menu in transactions tab.

Can also be setup on testnet, as testnet uses a different qt-settings file. To make the implementation simple, changing the option needs client restart to take effect.
laanwj commented at 6:54 AM on April 25, 2014: member

Looks ok to me.

Nit: please add a menu seperator between the 'normal' actions and the 'third party' actions.
cozz commented at 10:29 AM on April 25, 2014: contributor

I already added the menu separator, but after I made the screenshot.
laanwj added this to the milestone 0.9.2 on Apr 25, 2014
christophebiocca commented at 2:41 PM on April 25, 2014: none
I had some comments on your original pull, but I think they got lost when you refreshed it. I'll leave them here:
- Splitting a string on ;http seems really ugly. Can you use | as a separator (it's never valid in a url), or even better make the string a list?
- your logic to title case the domain name is going to look weird for live.insight.is. I'd just leave it verbatim.
[Qt] Optionally add third party links to transaction context menu 40c5b939f2
cozz commented at 6:12 PM on April 25, 2014: contributor
update:
- changed what @christophebiocca suggested. Thanks for the quick review.
```
    https://blockchain.info/tx/%s|https://blockexplorer.com/tx/%s|http://luckyb.it/browse?search=%s
```
BitcoinPullTester commented at 6:34 PM on April 25, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/40c5b939f2bff960e397da6ae3651952adc68cbe for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 6:19 AM on May 1, 2014: member

ACK
laanwj merged this on May 1, 2014
laanwj closed this on May 1, 2014
laanwj referenced this in commit d69427a0c4 on May 1, 2014
DrahtBot locked this on Sep 8, 2021

Contributors