Correct indentation #4109

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:FixNamespaceIndentation changing 1 files +45 −44
  1. rebroad commented at 7:00 AM on April 30, 2014: contributor

    Correct indentation.

  2. Correct indentation 6b29ccc9f9
  3. Diapolo commented at 12:37 PM on April 30, 2014: none

    ACK, did a diff and checked, just indentation fixes.

  4. BitcoinPullTester commented at 12:58 PM on April 30, 2014: none

    Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/6b29ccc9f9a166b54a9a0a026debe6244b77d805 for binaries and test log.

    This could happen for one of several reasons:

    1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
    2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
    3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
    4. The test suite fails on either Linux i386 or Win32
    5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)

    If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

    This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

  5. sipa commented at 12:58 PM on April 30, 2014: member

    It's uncommon to indent namspace blocks, because when they're used persistently, you often get entire .h files which are indented 2-3 levels.

    I'm not against this (as I agree it improves readability in this case), but if we want to increase the use of namespaces (I think we should), this is perhaps not a good idea. Opinions, @laanwj ?

  6. laanwj commented at 1:12 PM on April 30, 2014: member

    Agree @sipa. I think it can make sense to indent inner/nested namespaces, to distinguish them, but not the ones that surround the entire header/compilation unit.

    So in this case ACK for indenting the "internal stuff" only.

  7. laanwj merged this on May 1, 2014
  8. laanwj closed this on May 1, 2014

  9. laanwj referenced this in commit 191b087e0e on May 1, 2014
  10. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me