Remove build-time no-IPv6 setting #4115

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2014_05_ipv6 changing 6 files +0 −101

laanwj commented at 10:16 AM on May 1, 2014: member

The year is 2014. All supported operating systems have IPv6 support, most certainly at build time (this doesn't mean that IPv6 is configured, of course).

If noone is exercising the functionality to disable it, that means it doesn't get tested, and IMO it's better to get rid of it.

(it's also not used consistently in RPC/boost and Net code: if USE_IPV6 is not enabled, it is still assumed that boost is compiled with ipv6 support, so this would never work...)

Remove build-time no-IPv6 setting

The year is 2014. All supported operating systems have IPv6 support,
most certainly at build time (this doesn't mean that IPv6 is configured,
of course).

If noone is exercising the functionality to disable it, that means it
doesn't get tested, and IMO it's better to get rid of it.

(it's also not used consistently in RPC/boost and Net code...)

e27c4110d9

BitcoinPullTester commented at 3:08 PM on May 1, 2014: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/e27c4110d9c47d30fed4b940813c9c8b82a97fbd for binaries and test log.

This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
2. It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
3. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
4. The test suite fails on either Linux i386 or Win32
5. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.

This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
sipa commented at 9:53 PM on May 1, 2014: member

ACK idea & code.
jgarzik commented at 10:00 PM on May 1, 2014: contributor

untested ACK
Diapolo commented at 7:06 AM on May 2, 2014: none

Sounds like a good idea.
laanwj added this to the milestone 0.9.2 on May 2, 2014
laanwj commented at 8:27 AM on May 2, 2014: member

I checked that the bitcoind binary stays the same with and without this patch, apart from line numbers passed to assert_fail() and the git tag.
laanwj merged this on May 2, 2014
laanwj closed this on May 2, 2014
laanwj referenced this in commit bf35cae1ae on May 2, 2014
laanwj deleted the branch on May 2, 2014
laanwj restored the branch on May 9, 2014
DrahtBot locked this on Sep 8, 2021

Contributors