POSIX does not define sed's -i option. To stay as portable as possible we should not relay on it.
OpenBSD's sed does not support -i option for example.
Here is my suggested alternative.
don't use sed's -i option to stay posix compliant #4120
pull Mischi wants to merge 1 commits into bitcoin:master from Mischi:refactor-sed-posix-compliant changing 2 files +8 −8-
Mischi commented at 7:40 PM on May 2, 2014: contributor
-
dbe8f75262
don't use sed's -i option to stay posix compliant
POSIX does not define sed's -i option. To stay as portable as possible we should not relay on it.
-
BitcoinPullTester commented at 8:05 PM on May 2, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/dbe8f7526266092fe7b045dadaefb753feca15a6 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 7:04 AM on May 3, 2014: member
Where does this cause problems?
-
Mischi commented at 7:10 AM on May 3, 2014: contributor
Hi, for example OpenBSD/NetBSD does not have the -i option for sed.
-
laanwj commented at 7:23 AM on May 3, 2014: member
ok, ACK in that case
- laanwj merged this on May 5, 2014
- laanwj closed this on May 5, 2014
- laanwj referenced this in commit d4ffe4e425 on May 5, 2014
- DrahtBot locked this on Sep 8, 2021
Contributors