[Qt] Add -payreqselfsigned for testing #4121

pull aalness wants to merge 1 commits into bitcoin:master from aalness:aalness_payreqselfsigned changing 2 files +14 −0

aalness commented at 8:56 PM on May 2, 2014: contributor

This will allow for payment requests signed with self-signed certificates to be considered verified. This way the signature verification can be fully tested without a real CA-issued certificate.

[Qt] Add -payreqselfsigned for testing

This will allow for payment requests signed with self-signed certificates
to be considered verified. This way the signature verification can be
fully tested without a real CA-issued certificate.

1a738625fa

wozz commented at 6:38 PM on May 5, 2014: none

I think it makes more sense to create your own CA certificate, sign your certificate with that CA and add the CA certificate to your trusted certificate store. That will make sure to test that the trusted certificate store is configured properly as well.
mikehearn commented at 1:52 PM on May 19, 2014: contributor

Looks good to me.
gavinandresen commented at 2:15 PM on May 19, 2014: contributor

I think @wozz is correct; does passing: -rootcertificates=/path/to/self-signed-certificate.crt

... on the command-line get the same functionality as this patch? If it does, then updating documentation is better than adding yet another command-line option.
aalness commented at 7:07 AM on May 21, 2014: contributor

Agreed, I guess. From using tools like curl which provide a -k option I feel like programmers may not be inclined to first consider adding their self-signed test cert as a root. Do not feel strongly.

in src/init.cpp:None in 1a738625fa

 294 | @@ -295,6 +295,7 @@ std::string HelpMessage(HelpMessageMode hmm)
 295 |      }
 296 |      strUsage += "  -shrinkdebugfile       " + _("Shrink debug.log file on client startup (default: 1 when no -debug)") + "\n";
 297 |      strUsage += "  -testnet               " + _("Use the test network") + "\n";
 298 | +    strUsage += "  -payreqselfsigned      " + _("Consider payment requests signed with self-signed certificates as verified.") + "\n";

laanwj commented at 1:59 PM on May 28, 2014:

As this is a GUI-only option, add it to the help in utilitydialog.cpp instead of here: https://github.com/bitcoin/bitcoin/blob/master/src/qt/utilitydialog.cpp#L74

BitcoinPullTester commented at 10:11 AM on June 23, 2014: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4121_1a738625fa7c444b4d8aaa0b80e4ca038d6ec35c/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 3:20 PM on June 24, 2014: member

ACK after fixing my above remark, this needs to be a GUI-code-only change.
laanwj commented at 9:47 AM on July 30, 2014: member

Closing this due to inactivity, and also because it's already possible (albeit with an ugly command line).
laanwj closed this on Jul 30, 2014
DrahtBot locked this on Sep 8, 2021

Contributors