Currently a payment request is only checked for expiration upon receipt. It should be checked again immediately before sending coins to prevent the user from paying to an expired invoice which would then require a customer service interaction.
[Qt] Payment request expiration bug fix #4122
pull aalness wants to merge 1 commits into bitcoin:master from aalness:aalness_payreq_expires changing 1 files +14 −0-
aalness commented at 9:29 PM on May 2, 2014: contributor
-
5f5c4b5f92
[Qt] Payment request expiration bug fix
Currently a payment request is only checked for expiration upon receipt. It should be checked again immediately before sending coins to prevent the user from paying to an expired invoice which would then require a customer service interaction.
-
aalness commented at 10:31 PM on May 2, 2014: contributor
-
BitcoinPullTester commented at 9:56 AM on June 23, 2014: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/p4122_5f5c4b5f92ddfc528b97901da1fdff0334a8ed27/ for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 10:16 AM on June 23, 2014: member
The check looks sane; but ideally this validation logic should be in the wallet model, not the click event handler.
- laanwj added the label GUI on Jul 31, 2014
- laanwj added the label Wallet on Jul 31, 2014
-
-
Diapolo commented at 4:26 PM on November 21, 2014: none
This needs some love :), as it's rather important IMHO.
-
- laanwj added the label Priority Medium on Jan 8, 2015
-
-
- sipa closed this on Jan 9, 2015
- DrahtBot locked this on Sep 8, 2021
Contributors