Update BitRPC Script #4149

pull super3 wants to merge 2 commits into bitcoin:master from super3:bitrpc2 changing 1 files +172 −264

super3 commented at 10:27 PM on May 7, 2014: contributor

Special thanks to @jpiasetz. Doing a bit of testing now.
Update BitRPC Script
Special thanks to @jpiasetz
675a933894
Small Bug Fixes f2b2201014
in contrib/bitrpc/bitrpc.py:None in 675a933894 outdated
```
   0 | @@ -1,325 +1,232 @@
   1 | -from jsonrpc import ServiceProxy
   2 |  import sys
   3 |  import string
   4 | -import getpass
   5 | -
   6 | -# ===== BEGIN USER SETTINGS =====
```
laanwj commented at 6:53 AM on May 8, 2014:

Looks like you're removing any way to configure the user and password? What would be useful is to (optionally) parse the username/password from the user's bitcoin.conf, possibly given a datadir (like bitcoin-cli does).

super3 commented at 1:15 AM on May 13, 2014:

Good idea. Any guidance on how to pull the correct datadir in an platform independent way? In Window is usually %APPDATA%, whereas in Linux it usually .bitcoin. Should we just look in the expected places for each platform or is there a better way of doing that?

laanwj commented at 5:25 AM on May 13, 2014:

There is some code to read the default config here https://github.com/laanwj/bitcoin-python/blob/master/src/bitcoinrpc/config.py Seems it uses the default expected path on platforms, but there is no implementation for windows. It would be nice to be able to override the datadir using -datadir=XXX as well, just as with bitcoin-cli, in case someone changed the data directory.

super3 commented at 7:16 PM on May 13, 2014:

I guess the easiest way to do it is just to look in the expected paths. Do you know off the top of your head what the expected path string for Mac is?

gavinandresen commented at 4:10 PM on May 14, 2014:

See determine_db_dir() in https://github.com/bitcoin/bitcoin/blob/master/contrib/spendfrom/spendfrom.py#L35
BitcoinPullTester commented at 8:37 AM on June 23, 2014: none

Automatic sanity-testing: FAILED MERGE, see http://jenkins.bluematt.me/pull-tester/p4149_f2b2201014cebc8c37a05209689b003caa693bca/ for test log.

This pull does not merge cleanly onto current master This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 8:39 AM on June 23, 2014: member

Closing this pull, as it is out of date and appears to be inactive. Let me know if you continue development here.
laanwj closed this on Jun 23, 2014
DrahtBot locked this on Sep 8, 2021

Contributors